Refactor Nic._handle_nic_type method #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PolonaM
approved these changes
Mar 30, 2023
plugins/module_utils/type.py
Outdated
| RTL8139 = "RTL8139" | ||
| VIRTIO = "VIRTIO" | ||
| INTEL_E1000 = "INTEL_E1000" | ||
| class NicType: |
Collaborator
There was a problem hiding this comment.
I would just move this class to module_utils/nic.py (and delete type.py). But this is just my opinion, not necessary to change that. Otherwise nice job, I approve :)
Collaborator
Author
There was a problem hiding this comment.
Makes sense, will be done.
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
justinc1
force-pushed
the
refactor-NicType
branch
from
8785ab1 to
035c348
Compare
Signed-off-by: Justin Cinkelj <justin.cinkelj@xlab.si>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft: this requires #187 to be merged first - only last commit in refactor-NicType branch is relevant.
The
Nic._handle_nic_typemethod implemented conversion of NIC type from hypercore to ansible.But in code it was used also to "convert" from ansible to ansible - whis was wrong.
Unittest did pass because we had also wrong unittest data - mock data pretended HyperCore returns "virtio", but in reality "VIRTIO" is returned.
This is now changed, unittest mock data is fixed, and
Nic._handle_nic_typeis replaced withNicType.hypercore_to_ansible.